avijayanhwx commented on a change in pull request #1720:
URL: https://github.com/apache/ozone/pull/1720#discussion_r553782349
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/upgrade/HDDSLayoutFeatureCatalog.java
##########
@@ -39,7 +40,11 @@
private int layoutVersion;
private String description;
- private Optional< ? extends HDDSUpgradeAction> hddsUpgradeAction =
+
+ private Optional<? extends HDDSUpgradeAction> scmUpgradeAction =
+ Optional.empty();
+
+ private Optional<? extends HDDSUpgradeAction> datanodeUpgradeAction =
Review comment:
New approach looks good to me. Can we fix the CI issues? Also, do we
need to include the sample SCM and DN action that you have added in the latest
commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]