runzhiwang commented on a change in pull request #1780:
URL: https://github.com/apache/ozone/pull/1780#discussion_r558028612
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/BlockManagerImpl.java
##########
@@ -105,8 +105,10 @@ public BlockManagerImpl(final ConfigurationSource conf,
mxBean = MBeans.register("BlockManager", "BlockManagerImpl", this);
// SCM block deleting transaction log and deleting service.
- deletedBlockLog = new DeletedBlockLogImpl(conf, scm.getContainerManager(),
- scm.getScmMetadataStore());
+ deletedBlockLog = new DeletedBlockLogImplV2(conf,
scm.getContainerManager(),
+ scm.getScmHAManager().getRatisServer(),
+ scm.getScmMetadataStore().getDeletedBlocksTXTable(),
Review comment:
I pass deletedBlockTxTable to BlockManagerImpl, because I think
BlockManagerImpl should not see the entire metastore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
