bshashikant commented on a change in pull request #1780: URL: https://github.com/apache/ozone/pull/1780#discussion_r558099637
########## File path: hadoop-hdds/interface-server/src/main/proto/SCMRatisProtocol.proto ########## @@ -23,6 +23,7 @@ option java_generate_equals_and_hash = true; enum RequestType { PIPELINE = 1; CONTAINER = 2; + DELETE_BLOCK = 3; } Review comment: should we make this request type to be just BLOCK rather than DELETE_BLOCK ? For now, for blocks we only need to handle delete block info, but in future if we have to extend this for some block specific attributes, it would be more simple. For understanding as well, we can think of requests opearting at 3 levels, pipeline, container and blocks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org