xiaoyuyao commented on a change in pull request #1874:
URL: https://github.com/apache/ozone/pull/1874#discussion_r568792718
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/authority/CertificateServer.java
##########
@@ -101,26 +101,22 @@ X509Certificate getCertificate(String certSerialId)
/**
* Revokes a Certificate issued by this CertificateServer.
*
- * @param certificate - Certificate to revoke
- * @param approver - Approval process to follow.
+ * @param certificates - List of Certificates to revoke.
+ * @param reason - Reason for revocation.
+ * @param securityConfig - Security Configuration.
* @return Future that tells us what happened.
- * @throws SCMSecurityException - on Error.
- */
- Future<Boolean> revokeCertificate(X509Certificate certificate,
- ApprovalType approver) throws SCMSecurityException;
-
- /**
- * TODO : CRL, OCSP etc. Later. This is the start of a CertificateServer
- * framework.
Review comment:
NIT: javadoc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
