xiaoyuyao commented on a change in pull request #1874:
URL: https://github.com/apache/ozone/pull/1874#discussion_r568799029
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/authority/DefaultCAServer.java
##########
@@ -272,20 +272,22 @@ private X509CertificateHolder
signAndStoreCertificate(LocalDate beginDate,
}
@Override
- public Future<Boolean> revokeCertificate(X509Certificate certificate,
- CertificateApprover.ApprovalType approverType)
- throws SCMSecurityException {
+ public Future<Boolean> revokeCertificates(List<X509Certificate> certificates,
+ int reason,
+ SecurityConfig securityConfig) {
CompletableFuture<Boolean> revoked = new CompletableFuture<>();
- if (certificate == null) {
+ if (certificates == null || certificates.isEmpty()) {
Review comment:
NIT: we can use Collection#isEmptyOrNull here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
