symious commented on a change in pull request #1806:
URL: https://github.com/apache/ozone/pull/1806#discussion_r569118214
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/server/TestSCMBlockProtocolServer.java
##########
@@ -50,7 +50,7 @@
private StorageContainerManager scm;
private NodeManager nodeManager;
private ScmBlockLocationProtocolServerSideTranslatorPB service;
- private final int nodeCount = 10;
+ private static final int NODECOUNT = 10;
Review comment:
Fixed.
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestContainerPlacementFactory.java
##########
@@ -55,7 +55,7 @@
// datanodes array list
private List<DatanodeDetails> datanodes = new ArrayList<>();
// node storage capacity
- private final long storageCapacity = 100L;
+ private static final long STORAGECAPACITY = 100L;
Review comment:
Fixed.
##########
File path:
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestEndpoints.java
##########
@@ -133,27 +131,24 @@
private Pipeline pipeline;
private FileCountBySizeDao fileCountBySizeDao;
private DSLContext dslContext;
- private final String host1 = "host1.datanode";
- private final String host2 = "host2.datanode";
- private final String ip1 = "1.1.1.1";
- private final String ip2 = "2.2.2.2";
- private final String prometheusTestResponseFile =
+ private static final String HOST1 = "host1.datanode";
+ private static final String HOST2 = "host2.datanode";
+ private static final String IP1 = "1.1.1.1";
+ private static final String IP2 = "2.2.2.2";
+ private static final String PROMETHEUSTESTRESPONSEFILE =
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
