symious commented on a change in pull request #1806:
URL: https://github.com/apache/ozone/pull/1806#discussion_r569118342
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/security/TestOMGetDelegationTokenRequest.java
##########
@@ -56,7 +56,7 @@
private OMRequest originalRequest;
private OMRequest modifiedRequest;
private OMGetDelegationTokenRequest omGetDelegationTokenRequest;
- private final String checkResponse = "";
+ private static final String CHECKRESPONSE = "";
Review comment:
Fixed.
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyRequest.java
##########
@@ -78,8 +79,8 @@
protected OzoneBlockTokenSecretManager ozoneBlockTokenSecretManager;
protected ScmBlockLocationProtocol scmBlockLocationProtocol;
- protected final long containerID = 1000L;
- protected final long localID = 100L;
+ protected static final long CONTAINERID = 1000L;
+ protected static final long LOCALID = 100L;
Review comment:
Fixed.
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneClientRetriesOnException.java
##########
@@ -62,7 +62,7 @@
/**
* Tests failure detection and handling in BlockOutputStream Class.
*/
-public class TestOzoneClientRetriesOnException {
+public class TestOzoneClientRetriesOnException extends Exception {
Review comment:
Fixed.
##########
File path:
hadoop-hdds/config/src/test/java/org/apache/hadoop/hdds/conf/TestConfigFileGenerator.java
##########
@@ -36,7 +36,8 @@
@Test
public void testGeneratedXml() throws FileNotFoundException {
String generatedXml =
- new Scanner(new
File("target/test-classes/ozone-default-generated.xml"))
+ new Scanner(new
File("target/test-classes/ozone-default-generated.xml"),
+ "UTF-8")
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
