bharatviswa504 commented on a change in pull request #1916:
URL: https://github.com/apache/ozone/pull/1916#discussion_r573456440
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -699,6 +711,12 @@ public static boolean scmInit(OzoneConfiguration conf,
+ ";cid={};layoutVersion={}", scmStorageConfig.getStorageDir(),
scmStorageConfig.getClusterID(),
scmStorageConfig.getLayoutVersion());
+ //TODO: this check need not be done if ratis is not used.
+ // Initialize the raft group Id withe cluster Id.
+ if (isRatisEnabled(conf)) {
+ SCMRatisServerImpl.newRaftServer(clusterId, haDetails,
Review comment:
This part of initialization I have not understood why we need during
init, as anyway during SCM start we use clusterID and start RaftServer. Can you
share more info, why we need this during init step.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
