bshashikant commented on a change in pull request #1916:
URL: https://github.com/apache/ozone/pull/1916#discussion_r573464709



##########
File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -699,6 +711,12 @@ public static boolean scmInit(OzoneConfiguration conf,
             + ";cid={};layoutVersion={}", scmStorageConfig.getStorageDir(),
             scmStorageConfig.getClusterID(),
             scmStorageConfig.getLayoutVersion());
+        //TODO: this check need not be done if ratis is not used.
+        // Initialize the raft group Id withe cluster Id.
+        if (isRatisEnabled(conf)) {
+          SCMRatisServerImpl.newRaftServer(clusterId, haDetails,

Review comment:
       The idea here, is to just create and initialize the ratis group in init 
phase. When a ratis server starts up, the group should already exists. Thats 
way , we differentiate an scm node was initialized and this will immediately 
start a single node server and will become leader.
   
   The other nodes won't be initialised and after starting up, if figure out 
they don't belong to any group, first thing to do there is contact the leader 
by going through each SCM round-robin , initiate an alredy exiting leader to 
execute setConf to add , it to the ratis ring.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to