bshashikant commented on a change in pull request #1916:
URL: https://github.com/apache/ozone/pull/1916#discussion_r576238172
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java
##########
@@ -80,13 +80,18 @@ public SCMStateMachine(final StorageContainerManager scm,
}
}
+ public SCMStateMachine() {
Review comment:
I think its ok to not create instantiate any SCM sever instance. If any
other method gets called suring ratis server spin up, we need to handle that in
SCM anyways..
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java
##########
@@ -80,13 +80,18 @@ public SCMStateMachine(final StorageContainerManager scm,
}
}
+ public SCMStateMachine() {
Review comment:
I think its ok to not create instantiate any SCM sever instance. If any
other method gets called during ratis server spin up, we need to handle that in
SCM anyways..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
