bshashikant commented on a change in pull request #1916:
URL: https://github.com/apache/ozone/pull/1916#discussion_r576581425
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMStorageConfig.java
##########
@@ -76,6 +98,11 @@ protected Properties getNodeProperties() {
}
Properties scmProperties = new Properties();
scmProperties.setProperty(SCM_ID, scmId);
+ String scmNodeInfo = getScmNodeInfo();
+ if (scmNodeInfo != null) {
+ // FOR NON-HA setup, SCM_NODES can be null
Review comment:
I guess, we need to handle upgrades if we use this for non-HA cluster.
Not sure we should this right away.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
