bharatviswa504 commented on a change in pull request #1958:
URL: https://github.com/apache/ozone/pull/1958#discussion_r582644190
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/authority/CertificateServer.java
##########
@@ -82,7 +82,7 @@ X509Certificate getCertificate(String certSerialId)
*/
Future<X509CertificateHolder> requestCertificate(
PKCS10CertificationRequest csr,
- CertificateApprover.ApprovalType type)
+ CertificateApprover.ApprovalType type, boolean scmCert)
Review comment:
Yes for now in this PR will only address for SCM, I can open a new Jira
to do for other roles. So, that it will help during list with role type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
