adoroszlai commented on a change in pull request #1958:
URL: https://github.com/apache/ozone/pull/1958#discussion_r582665288
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/protocol/SCMSecurityProtocol.java
##########
@@ -62,6 +63,18 @@ String getDataNodeCertificate(
String getOMCertificate(OzoneManagerDetailsProto omDetails,
String certSignReq) throws IOException;
+
+ /**
+ * Get SCM signed certificate for OM.
+ *
+ * @param scmNodeDetails - DataNode Details.
+ * @param certSignReq - Certificate signing request.
+ * @return String - pem encoded SCM signed
+ * certificate.
+ */
+ String generateSCMPeerCertificate(ScmNodeDetailsProto scmNodeDetails,
Review comment:
Can we name it `get...` now, and rename with the rest? I know it's a
bit more work, but there are some benefits:
1. They are consistent with one another both before and after the rename.
2. If renaming should turn out to be not possible (eg. because it might
introduce incompatibility) or not desired (eg. someone might argue that `get`
reflects the operation more closely), then we are not stuck with inconsistent
names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
