guihecheng commented on a change in pull request #1955:
URL: https://github.com/apache/ozone/pull/1955#discussion_r585190591



##########
File path: 
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBProfile.java
##########
@@ -105,8 +105,26 @@ public ColumnFamilyOptions getColumnFamilyOptions() {
       columnFamilyOptions.setCompactionStyle(CompactionStyle.LEVEL);
       return columnFamilyOptions;
     }
+  },
+  // NOTE: just for unit test now, don't use it in production
+  TEST {

Review comment:
       @adoroszlai well, I admit that there merely any difference to check the 
DBOptions or ColumnFamilyOptions, here I intended to check the 
ColumnFamilyOptions just because it is convenient to use the existing 
OPTIONS_CACHE in AbstractDatanodeStore.
   So to check the DBOptions, I'll try to export the DBOptions as well(or the 
DBProfile directly), just for test, what do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to