guihecheng commented on a change in pull request #1955:
URL: https://github.com/apache/ozone/pull/1955#discussion_r594162998



##########
File path: 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/metadata/AbstractDatanodeStore.java
##########
@@ -243,8 +253,7 @@ private static ColumnFamilyOptions buildColumnFamilyOptions(
         .setPinL0FilterAndIndexBlocksInCache(true)

Review comment:
       > nit: I think we can remove lines 238-239 `RocksDB.loadLibrary` since 
this method is no longer static.
   
   oh, by reading the comment in the code, it seems to be reasonable to remove 
this line, but I'll check and test it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to