umamaheswararao commented on a change in pull request #1973:
URL: https://github.com/apache/ozone/pull/1973#discussion_r585835208
##########
File path:
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto
##########
@@ -206,6 +206,10 @@ message ContainerReplicaProto {
optional int64 deleteTransactionId = 11;
optional uint64 blockCommitSequenceId = 12;
optional string originNodeId = 13;
+ //the index of this replica in the replication group.
+ //this will be different for each instance in case of EC
+ //but the same (0) for all instances for standard Ratis
+ optional int32 replicationIndex = 14;
Review comment:
I see this index added only ContainerReplica: but if we don't add it to
ContainerID itself, this might leads to more changes.
example: Once we received container replica report, the below API we use to
updateContainerReplica:
So, your thought is to add another field in this kind of API to carry index?
otherwise we need to add that in ContainerID also.
```
private void updateContainerReplica(final DatanodeDetails datanodeDetails,
final ContainerID containerId,
final ContainerReplicaProto
replicaProto)
throws ContainerNotFoundException, ContainerReplicaNotFoundException {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
