elek commented on a change in pull request #1973:
URL: https://github.com/apache/ozone/pull/1973#discussion_r589290739
##########
File path:
hadoop-hdds/interface-server/src/main/proto/ScmServerDatanodeHeartbeatProtocol.proto
##########
@@ -206,6 +206,10 @@ message ContainerReplicaProto {
optional int64 deleteTransactionId = 11;
optional uint64 blockCommitSequenceId = 12;
optional string originNodeId = 13;
+ //the index of this replica in the replication group.
+ //this will be different for each instance in case of EC
+ //but the same (0) for all instances for standard Ratis
+ optional int32 replicationIndex = 14;
Review comment:
Sorry, I didn't get the challenge here. Can you please explain it in
more details?
I am not sure if it's an answer: but I would prefer to keep it in a
separated field to make sure we add it only when it's needed. It provides more
visibility and code path which more easy to understand...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
