xiaoyuyao commented on a change in pull request #2008: URL: https://github.com/apache/ozone/pull/2008#discussion_r591673118
########## File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/OzonePrefixPath.java ########## @@ -0,0 +1,59 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.ozone.security.acl; + +import org.apache.hadoop.ozone.om.helpers.OzoneFileStatus; + +import java.io.IOException; +import java.util.List; + +public interface OzonePrefixPath { + + /** + * Lists immediate children(files or a directories) of the given keyPrefix. + * It won't do recursive traversal. + * + * Assume following is the Ozone FS tree structure. + * + * buck-1 + * | + * a + * | + * ----------------------------------- + * | | | + * b1 b2 b3 + * ----- -------- ---------- + * | | | | | | | | + * c1 c2 d1 d2 d3 e1 e2 e3 + * | | + * -------- | + * | | | + * d21.txt d22.txt e11.txt + * + * Say, KeyPrefix = "a" will return immediate children [a/b1, a/b2, a/b3]. + * Say, KeyPrefix = "a/b2" will return children [a/b2/d1, a/b2/d2, a/b2/d3]. + * + * @param volumeName volume name + * @param bucketName bucket name + * @param keyPrefix keyPrefix name + * @return list of immediate files or directories under the given keyPrefix. + * @throws IOException + */ + List<OzoneFileStatus> getChildren(String volumeName, Review comment: That looks good to me. ########## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java ########## @@ -1828,6 +1828,57 @@ public boolean checkAcls(ResourceType resType, StoreType storeType, } } + /** + * CheckAcls for the ozone object. + * + * @return true if permission granted, false if permission denied. + * @throws OMException ResultCodes.PERMISSION_DENIED if permission denied + * and throwOnPermissionDenied set to true. + */ + @SuppressWarnings("parameternumber") + public boolean checkAcls(ResourceType resType, StoreType storeType, + ACLType aclType, String vol, String bucket, String key, + UserGroupInformation ugi, InetAddress remoteAddress, String hostName, + boolean throwIfPermissionDenied, String volumeOwner, + boolean recursiveAccessCheck) + throws OMException { + OzoneObj obj = OzoneObjInfo.Builder.newBuilder() + .setResType(resType) + .setStoreType(storeType) + .setVolumeName(vol) + .setBucketName(bucket) + .setKeyName(key).build(); + RequestContext context = RequestContext.newBuilder() Review comment: No I mean we have many checkAcls() with lots of parameters and each time, we add one more, the chain will be extended longer. Instead of doing that, we can pass the wrapper RequestContext or its Builder for checkAcls parameter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
