rakeshadr commented on a change in pull request #2008:
URL: https://github.com/apache/ozone/pull/2008#discussion_r596293496
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/RequestContext.java
##########
@@ -43,20 +43,23 @@
*/
private final boolean recursiveAccessCheck;
+ private final OzonePrefixPath ozonePrefixPath;
+
@SuppressWarnings("parameternumber")
public RequestContext(String host, InetAddress ip,
UserGroupInformation clientUgi, String serviceId,
ACLIdentityType aclType, ACLType aclRights,
String ownerName) {
this(host, ip, clientUgi, serviceId, aclType, aclRights, ownerName,
- false);
+ false, null);
}
@SuppressWarnings("parameternumber")
public RequestContext(String host, InetAddress ip,
UserGroupInformation clientUgi, String serviceId,
ACLIdentityType aclType, ACLType aclRights,
- String ownerName, boolean recursiveAccessCheck) {
+ String ownerName, boolean recursiveAccessCheck,
+ OzonePrefixPath ozonePrefixPath) {
Review comment:
Thanks @xiaoyuyao for the comment. Agreed.
I hope you are thinking that, OzoneObject has reference to `volume, bucket
and keyname` attributes, so we can also add `ozonePrefixPath` to OzoneObject to
make it more sense. Am I correct?
Is that `recursiveAccessCheck` flag in RequestContext work instead of adding
a new flag to indicates the check for prefixPath?
Now, `recursiveAccessCheck` flag will be true for any directory and false
otherwise. I'm setting the value in OMKeyRenameRequestV1 and
OMKeyDeleteRequestV1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
