GlenGeng commented on a change in pull request #2052:
URL: https://github.com/apache/ozone/pull/2052#discussion_r595772986
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisRequest.java
##########
@@ -86,9 +94,14 @@ public Message encode() throws
InvalidProtocolBufferException {
methodBuilder.setName(operation);
final List<MethodArgument> args = new ArrayList<>();
+
+ int paramCounter = 0;
for (Object argument : arguments) {
final MethodArgument.Builder argBuilder = MethodArgument.newBuilder();
- argBuilder.setType(argument.getClass().getName());
+ // Set actual method parameter type, not actual argument type.
+ // This is done to avoid MethodNotFoundException in case if argument is
Review comment:
Nice change!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
