JacksonYao287 commented on a change in pull request #2079:
URL: https://github.com/apache/ozone/pull/2079#discussion_r600407420
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestSequenceIDGenerator.java
##########
@@ -70,8 +73,6 @@ public void testSequenceIDGenUponNonRatis() throws Exception {
@Test
public void testSequenceIDGenUponRatis() throws Exception {
OzoneConfiguration conf = SCMTestUtils.getConf();
- // enable ratis based SequenceIDGen
- conf.setBoolean(OZONE_SCM_HA_ENABLE_KEY, true);
Review comment:
before this commit, how a stateManager of a sequenceIdGenerator is build
depend on this configuration
```
if (SCMHAUtils.isSCMHAEnabled(conf)) {
this.stateManager = new StateManagerHAImpl.Builder()
.setRatisServer(scmhaManager.getRatisServer())
.setDBTransactionBuffer(scmhaManager.getDBTransactionBuffer())
.setSequenceIdTable(sequenceIdTable)
.build();
} else {
this.stateManager = new StateManagerImpl(sequenceIdTable);
}
```
but now , it is no use here and a sequenceIdGenerator is build totally
depend on scmHAManager。
but we can also keep this configuration here， it does not matter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
