GlenGeng commented on a change in pull request #2079:
URL: https://github.com/apache/ozone/pull/2079#discussion_r601020384
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SequenceIdGenerator.java
##########
@@ -91,15 +91,11 @@ public SequenceIdGenerator(ConfigurationSource conf,
this.batchSize = conf.getInt(OZONE_SCM_SEQUENCE_ID_BATCH_SIZE,
OZONE_SCM_SEQUENCE_ID_BATCH_SIZE_DEFAULT);
- if (SCMHAUtils.isSCMHAEnabled(conf)) {
- this.stateManager = new StateManagerHAImpl.Builder()
- .setRatisServer(scmhaManager.getRatisServer())
- .setDBTransactionBuffer(scmhaManager.getDBTransactionBuffer())
- .setSequenceIdTable(sequenceIdTable)
- .build();
- } else {
- this.stateManager = new StateManagerImpl(sequenceIdTable);
- }
+ Preconditions.checkNotNull(scmhaManager);
+ this.stateManager = new StateManagerHAImpl.Builder()
Review comment:
enhance java doc `null if non-Ratis based`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
