nandakumar131 commented on code in PR #7526:
URL: https://github.com/apache/ozone/pull/7526#discussion_r1872833970
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/cli/GenericCli.java:
##########
@@ -63,25 +61,11 @@ public GenericCli(Class<?> type) {
});
if (type != null) {
- addSubcommands(getCmd(), type);
+ SubcommandWithParent.addSubcommands(getCmd(), type);
}
ExtensibleParentCommand.addSubcommands(cmd);
Review Comment:
Just a question for my understanding: Right now we are still loading all the
available sub commands that implements `SubcommandWithParent`? We will keep
doing this until we completely move to fine-grained interface for all the
sub-commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
