adoroszlai commented on code in PR #7526:
URL: https://github.com/apache/ozone/pull/7526#discussion_r1872972289
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/cli/GenericCli.java:
##########
@@ -63,25 +61,11 @@ public GenericCli(Class<?> type) {
});
if (type != null) {
- addSubcommands(getCmd(), type);
+ SubcommandWithParent.addSubcommands(getCmd(), type);
}
ExtensibleParentCommand.addSubcommands(cmd);
Review Comment:
Removing the `type` parameter may not be ideal, as some subclasses are not
be intended to be extensible (mostly server-side component starter commands,
like `OzoneManagerStarter` or `HddsDatanodeService`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
