hemantk-12 commented on code in PR #7549:
URL: https://github.com/apache/ozone/pull/7549#discussion_r1878886553
##########
hadoop-hdds/rocksdb-checkpoint-differ/src/main/java/org/apache/ozone/rocksdiff/RocksDBCheckpointDiffer.java:
##########
@@ -898,8 +897,13 @@ public synchronized List<String> getSSTDiffList(
filterRelevantSstFilesFullPath(fwdDAGDifferentFiles,
src.getTablePrefixes());
}
-
- return new ArrayList<>(fwdDAGDifferentFiles);
+ // Check if the DAG traversal was able to reach all the destination SST
files.
+ for (String destSnapFile : destSnapFiles) {
+ if (!fwdDAGSameFiles.contains(destSnapFile) ||
!fwdDAGDifferentFiles.contains(destSnapFile)) {
+ return Optional.empty();
+ }
+ }
Review Comment:
Move this before if at line 896. Otherwise, it can return some delta files
which can later be deleted by SstFilteringSerivce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
