hemantk-12 commented on code in PR #7549:
URL: https://github.com/apache/ozone/pull/7549#discussion_r1881242123
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1139,9 +1139,11 @@ Set<String> getDeltaFiles(OmSnapshot fromSnapshot,
LOG.debug("Calling RocksDBCheckpointDiffer");
try {
- List<String> sstDiffList = differ.getSSTDiffListWithFullPath(toDSI,
+ Optional<List<String>> sstDiffList =
differ.getSSTDiffListWithFullPath(toDSI,
Review Comment:
Address HDDS-11818 here as well by declaring Optional outside the try-catch?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java:
##########
@@ -1139,9 +1139,11 @@ Set<String> getDeltaFiles(OmSnapshot fromSnapshot,
LOG.debug("Calling RocksDBCheckpointDiffer");
try {
- List<String> sstDiffList = differ.getSSTDiffListWithFullPath(toDSI,
+ Optional<List<String>> sstDiffList =
differ.getSSTDiffListWithFullPath(toDSI,
Review Comment:
Maybe address HDDS-11818 here as well by declaring Optional outside the
try-catch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
