bharatviswa504 commented on a change in pull request #2000:
URL: https://github.com/apache/ozone/pull/2000#discussion_r603025764
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMSecurityProtocolServer.java
##########
@@ -268,7 +286,7 @@ public String getCACertificate() throws IOException {
public List<String> listCertificate(NodeType role,
long startSerialId, int count, boolean isRevoked) throws IOException {
List<X509Certificate> certificates =
- certificateServer.listCertificate(role, startSerialId, count,
+ rootCertificateServer.listCertificate(role, startSerialId, count,
Review comment:
This API semantics is not changed it can return list of certificates for
all roles.
As scmcertserver runs on all SCM's used the scmcertserver
Underlying both CertificateServers use the same certstore. So, the semantics
of this API is not changed, it can get any certificate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
