xiaoyuyao commented on a change in pull request #2000:
URL: https://github.com/apache/ozone/pull/2000#discussion_r604438524
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMSecurityProtocolServer.java
##########
@@ -288,22 +306,18 @@ public String getCACertificate() throws IOException {
public List<String> listCACertificate() throws IOException {
List<String> caCerts =
listCertificate(NodeType.SCM, 0, 10, false);
- caCerts.add(getRootCACertificate());
return caCerts;
}
@Override
public String getRootCACertificate() throws IOException {
LOGGER.debug("Getting Root CA certificate.");
- //TODO: This code will be modified after HDDS-4897 is merged and
- // integrated. For now getting RootCA cert from certificateServer.
- try {
+ if (storageContainerManager.getScmStorageConfig()
Review comment:
Can we pass in the Root CA certificate to the security protocol server
without calling back into the cert client from scm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
