sadanand48 commented on code in PR #7497:
URL: https://github.com/apache/ozone/pull/7497#discussion_r1882476065
##########
.github/workflows/ci.yml:
##########
@@ -27,15 +27,14 @@ on:
default: ''
required: false
env:
- FAIL_FAST: ${{ github.event_name == 'pull_request' }}
+ BUILD_ARGS: "-Pdist -Psrc -Dmaven.javadoc.skip=true"
# Minimum required Java version for running Ozone is defined in pom.xml
(javac.version).
TEST_JAVA_VERSION: 21 # JDK version used by CI build and tests; should match
the JDK version in apache/ozone-runner image
+ # MAVEN_ARGS and MAVEN_OPTS are duplicated in check.yml, please keep in sync
Review Comment:
why is this done ? can't we pass these to check.yml via env
##########
hadoop-ozone/dev-support/checks/build.sh:
##########
@@ -14,7 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-set -eu -o pipefail
+set -u -o pipefail
Review Comment:
why did we remove -e here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
