adoroszlai commented on code in PR #7497:
URL: https://github.com/apache/ozone/pull/7497#discussion_r1882550888
##########
.github/workflows/ci.yml:
##########
@@ -27,15 +27,14 @@ on:
default: ''
required: false
env:
- FAIL_FAST: ${{ github.event_name == 'pull_request' }}
+ BUILD_ARGS: "-Pdist -Psrc -Dmaven.javadoc.skip=true"
# Minimum required Java version for running Ozone is defined in pom.xml
(javac.version).
TEST_JAVA_VERSION: 21 # JDK version used by CI build and tests; should match
the JDK version in apache/ozone-runner image
+ # MAVEN_ARGS and MAVEN_OPTS are duplicated in check.yml, please keep in sync
Review Comment:
> can't we pass these to check.yml via env
Unfortunately not.
We can pass inputs to `check.yml` via `with`, like:
https://github.com/apache/ozone/blob/303e3bf4bfc66ae3aa5cab50c9b73dee88b0ef6d/.github/workflows/ci.yml#L113-L116
However, we cannot use `${{ env.MAVEN_ARGS }}` in item of `with`. Only
`github` and `needs` contexts are available.
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idwithinput_id
Some of the other environment variables we pass by adding as `output` of
`build-info` (so via `needs`):
https://github.com/apache/ozone/blob/303e3bf4bfc66ae3aa5cab50c9b73dee88b0ef6d/.github/workflows/ci.yml#L55-L58
https://github.com/apache/ozone/blob/303e3bf4bfc66ae3aa5cab50c9b73dee88b0ef6d/.github/workflows/ci.yml#L119
- `OZONE_WITH_COVERAGE` has logic based on the event that triggers `ci.yml`,
we cannot access that in `check.yml`.
- `build-args` and `java-version` are passed to inputs that exist anyway.
I didn't want to add new inputs for these `MAVEN_` constants. Duplication
seemed to be the better choice in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
