sadanand48 commented on code in PR #7365:
URL: https://github.com/apache/ozone/pull/7365#discussion_r1889815044
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/AbstractKeyDeletingService.java:
##########
@@ -388,7 +393,7 @@ protected PurgePathRequest prepareDeleteDirRequest(
// limit. If count reached limit then there can be some more child
// paths to be visited and will keep the parent deleted directory
// for one more pass.
- String purgeDeletedDir = remainNum > 0 ? delDirName : null;
+ String purgeDeletedDir = (remainNum > 0 && remainingBufLimit > 0) ?
delDirName : null;
Review Comment:
acc to current logic if remainBufLimit = 5 it will include the record with
recordSize 10 and the remainBufLimit would be updated to 5-10 = -5. With this
the above logic will work . We already maintain some extra buffer when
initialising remainBufLimit to handle overflow.
anyways I will need to change the logic while incorporating other comments
so this would be taken care of. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
