sadanand48 commented on code in PR #7365: URL: https://github.com/apache/ozone/pull/7365#discussion_r1904954861
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/DeleteKeysResult.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.ozone.om; + +import org.apache.hadoop.ozone.om.helpers.OmKeyInfo; + +import java.util.List; + +/** + * Used in {@link org.apache.hadoop.ozone.om.service.DirectoryDeletingService} + * to capture the result of each delete task. + */ +public class DeleteKeysResult { + + private List<OmKeyInfo> keysToDelete; + private long consumedSize; Review Comment: Since we are tracking consumedSize and it is subtracted by remainingBufLimit, it will fail in this condition so I think it should get handled. ``` if (remainingBufLimit - objectSerializedSize < 0){ break; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
