sumitagrawl commented on PR #7602: URL: https://github.com/apache/ozone/pull/7602#issuecomment-2559045895
> Thanks @sumitagrawl for the patch. > > I think we can keep using `TermIndex` even if the index is not generated by Ratis, similar to how it's used currently when Ratis is disabled in OM. `TermIndex` is just an interface, we can define custom implementation, if additional data is needed for generating our own index. Thus we could avoid wrapping it in yet another object, and skip refactoring a bunch of code. @adoroszlai ExecutionContext here have just one entry, but in new flow, it’s context for execution which will contains other members as required in future like both index and termIndex. Additional other parameters. It’s problem to change interface for every new parameters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
