adoroszlai commented on PR #7602: URL: https://github.com/apache/ozone/pull/7602#issuecomment-2559326805
> ExecutionContext here have just one entry, but in new flow, it’s context for execution which will contains other members as required in future like both index and termIndex. Additional other parameters. It’s problem to change interface for every new parameters. - in POC (#7406) `ExecutionContext` has one additional member: `batchOperation` - `ExecutionContext` is just a holder for "stuff", with `get`/`set` methods for each member - `index`/`termIndex` and `batchOperation` are used in unrelated places - instances of `ExecutionContext` may or may not have these members set - `RequestContext` is also a holder for "stuff" - `RequestContext` even has entry for `ExecutionContext` So I think `ExecutionContext` is unnecessary and prone to be misused. Why not put additional other parameters (`batchOperation` for now) in `RequestContext`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
