devmadhuu commented on code in PR #7517:
URL: https://github.com/apache/ozone/pull/7517#discussion_r1901681210
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java:
##########
@@ -168,55 +180,44 @@ private void ignoreFailedTasks(List<String> failedTasks) {
@Override
public synchronized void reInitializeTasks(
ReconOMMetadataManager omMetadataManager) throws InterruptedException {
- try {
- Collection<Callable<Pair<String, Boolean>>> tasks = new ArrayList<>();
- for (Map.Entry<String, ReconOmTask> taskEntry :
- reconOmTasks.entrySet()) {
- ReconOmTask task = taskEntry.getValue();
- tasks.add(() -> task.reprocess(omMetadataManager));
- }
- List<Future<Pair<String, Boolean>>> results =
- executorService.invokeAll(tasks);
- for (Future<Pair<String, Boolean>> f : results) {
+ Collection<Callable<Pair<String, Boolean>>> tasks = new ArrayList<>();
+ for (Map.Entry<String, ReconOmTask> taskEntry :
+ reconOmTasks.entrySet()) {
+ ReconOmTask task = taskEntry.getValue();
+ ReconTaskStatusUpdater taskStatusUpdater =
getUpdaterForTask(task.getTaskName());
+ taskStatusUpdater.setIsCurrentTaskRunning(1);
+ taskStatusUpdater.setLastUpdatedTimestamp(System.currentTimeMillis());
+ taskStatusUpdater.updateDetails();
+ tasks.add(() -> task.reprocess(omMetadataManager));
Review Comment:
Pls revisit this code. In case of any runtime exception in case of full
snapshot reprocess for any downstream task, there is not correct handling and
capture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
