devmadhuu commented on code in PR #7517:
URL: https://github.com/apache/ozone/pull/7517#discussion_r1918531507
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -499,6 +478,11 @@ void getAndApplyDeltaUpdatesFromOM(
inLoopStartSequenceNumber = inLoopLatestSequenceNumber;
loopCount++;
}
+ // We might reach loop count limit and so not all updates from RocksDB
might be applied.
+ // Say we have: 1000 updates, each loop we get only 100 updates, loop
limit is 5.
+ // So this will effectively only apply 500 events, even if we are having
total 1000 updates/events;
+ // All subsequent tasks will effectively process only 500 events, till
next sync takes place.
Review Comment:
Not understood this comment clearly.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -555,12 +539,21 @@ boolean innerGetAndApplyDeltaUpdatesFromOM(long
fromSequenceNumber,
}
/**
- * Based on current state of Recon's OM DB, we either get delta updates or
- * full snapshot from Ozone Manager.
+ * This method performs the syncing of data from OM.
+ * <ul>
+ * <li>Initially it will fetch a snapshot of OM DB.</li>
+ * <li>If we already have data synced it will try to fetch delta
updates.</li>
+ * <li>If the sync is completed successfully it will trigger other OM
tasks to process events</li>
+ * <li>If there is any exception while trying to fetch delta updates, it
will fall back to snapshot update</li>
Review Comment:
```suggestion
* <li>If there is any exception while trying to fetch delta updates, it
will fall back to full snapshot update</li>
```
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/spi/impl/OzoneManagerServiceProviderImpl.java:
##########
@@ -555,12 +539,21 @@ boolean innerGetAndApplyDeltaUpdatesFromOM(long
fromSequenceNumber,
}
/**
- * Based on current state of Recon's OM DB, we either get delta updates or
- * full snapshot from Ozone Manager.
+ * This method performs the syncing of data from OM.
+ * <ul>
+ * <li>Initially it will fetch a snapshot of OM DB.</li>
+ * <li>If we already have data synced it will try to fetch delta
updates.</li>
+ * <li>If the sync is completed successfully it will trigger other OM
tasks to process events</li>
+ * <li>If there is any exception while trying to fetch delta updates, it
will fall back to snapshot update</li>
+ * <li>If there is any exception in snapshot sync it will do nothing.</li>
Review Comment:
Didn't understand this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
