adoroszlai commented on code in PR #7495:
URL: https://github.com/apache/ozone/pull/7495#discussion_r1910061386
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/helpers/TestContainerUtils.java:
##########
@@ -133,6 +154,15 @@ private void assertWriteRead(@TempDir File tempDir,
assertEquals(details.getCurrentVersion(), read.getCurrentVersion());
}
+ private void assertWriteReadWithChangedIpAddress(@TempDir File tempDir,
+ DatanodeDetails details)
throws IOException {
Review Comment:
I don't think there is any strong preference we agreed on, but you can't go
wrong by following existing style from the same file being edited:
https://github.com/apache/ozone/blob/f1fdd50ce0e01a578ab0b31b65cb53611f514eb5/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/helpers/TestContainerUtils.java#L145-L146
Some would argue for:
- putting each argument on a separate line vs. grouping few of them while
respecting line length limit
- putting the first argument on its own line
Consistent formatting has benefits, but coming to agreement is not easy, and
reformatting all existing code makes backports harder initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
