adoroszlai opened a new pull request, #7704:
URL: https://github.com/apache/ozone/pull/7704

   ## What changes were proposed in this pull request?
   
   Problem:
   `TestChunkInputStream` and `TestKeyInputStream` repeat tests with default 
container layout, instead of testing with both `FILE_PER_BLOCK` and 
`FILE_PER_CHUNK`.
   
   Causes:
   - The tests set wrong string representation of the configured container 
layout (since HDDS-4552).  Test cluster always falls back to the default 
layout, `FILE_PER_BLOCK`.
   - `KeyValueHandler` does not allow creating containers with `FILE_PER_CHUNK` 
layout, even if configured correctly (since HDDS-11753).
   
   Fix:
   - Change the tests to start the cluster only once, with the default layout.
   - Set the layout in datanode configs right before creating data.
   - Close existing containers afterwards, to ensure each test writes data to 
new container, created with the layout being tested.
   
   https://issues.apache.org/jira/browse/HDDS-12081
   
   ## How was this patch tested?
   
   Added temporary log in `KeyValueHandler.handleCreateContainer` to show the 
layout being used.
   
   
https://github.com/apache/ozone/blob/0723902ac927d19faeab735c0d1fcd8339fb58b6/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java#L395-L399
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/12783565176
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to