dombizita commented on code in PR #7528: URL: https://github.com/apache/ozone/pull/7528#discussion_r1922445105
########## hadoop-ozone/dist/src/main/smoketest/debug/ozone-debug-tests-ec3-2.robot: ########## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +*** Settings *** +Documentation Test ozone Debug CLI for EC(3,2) replicated keys +Library OperatingSystem +Library Process +Resource ../lib/os.robot +Resource ozone-debug.robot +Test Timeout 5 minute +Suite Setup Create Volume Bucket + +*** Variables *** +${PREFIX} ${EMPTY} +${VOLUME} cli-debug-volume${PREFIX} +${BUCKET} cli-debug-bucket +${TESTFILE} testfile +${EC_DATA} 3 +${EC_PARITY} 2 + +*** Keywords *** +Create Volume Bucket + Execute ozone sh volume create o3://om/${VOLUME} + Execute ozone sh bucket create o3://om/${VOLUME}/${BUCKET} + +Create EC key + [arguments] ${bs} ${count} + + Execute dd if=/dev/urandom of=${TEMP_DIR}/testfile bs=${bs} count=${count} + Execute ozone sh key put o3://om/${VOLUME}/${BUCKET}/testfile ${TEMP_DIR}/testfile -r rs-${EC_DATA}-${EC_PARITY}-1024k -t EC Review Comment: This `Create EC key` is called in evert test case and the key name (`testfile`) is the same each time? I'm not sure how does this run successfully at all, as we create the key on the same path several times. Could you check this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
