peterxcli commented on code in PR #7528:
URL: https://github.com/apache/ozone/pull/7528#discussion_r1930984867
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1615,6 +1634,34 @@ public OzoneInputStream getKey(
return result;
}
+ /**
+ * Helper method to calculate the internal block length of an EC-replicated
key.
+ * The length of data blocks differs depending on whether it is the last
strip or not.
+ * That of parity blocks can be determined by the data blocks.
+ */
+ private long internalBlockLength(int index, ECReplicationConfig ecRepConfig,
long blockLength) {
Review Comment:
Should we consider unifying these two methods? It seems critical to ensure
consistency, and it might be better to place this logic in a shared location
that everyone can access and reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
