devmadhuu commented on PR #7743: URL: https://github.com/apache/ozone/pull/7743#issuecomment-2617940195
> Thanks for the patch @devmadhuu. nit: Have you also considered optimizing `nsSummary.setNumOfFiles(nsSummary.getNumOfFiles() + 1);` and `nsSummary.setSizeOfFiles(nsSummary.getSizeOfFiles() + dataSize);` in `NSSummaryTaskDbEventHandler.handlePutKeyEvent()` and `NSSummaryTaskDbEventHandler.handleDeleteDirEvent()` > > LGTM otherwise Thanks @SaketaChalamchala for the review. I have optimized code in `NSSummaryTaskDbEventHandler` as well. Pls review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
