dombizita commented on code in PR #7743:
URL: https://github.com/apache/ozone/pull/7743#discussion_r1932179404
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmTableInsightTask.java:
##########
@@ -295,21 +286,23 @@ private void writeDataToDB(Map<String, Long> dataMap) {
globalStatsDao.insert(insertGlobalStats);
globalStatsDao.update(updateGlobalStats);
+
+ insertGlobalStats.clear();
+ updateGlobalStats.clear();
}
/**
* Initializes and returns a count map with the counts for the tables.
*
* @return The count map containing the counts for each table.
*/
- private HashMap<String, Long> initializeCountMap() {
- Collection<String> tables = getTaskTables();
Review Comment:
How do we make sure that `tables` is initialised here?
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmTableInsightTask.java:
##########
@@ -157,35 +166,32 @@ public Collection<String> getTaskTables() {
@Override
public Pair<String, Boolean> process(OMUpdateEventBatch events) {
Iterator<OMDBUpdateEvent> eventIterator = events.getIterator();
- // Initialize maps to store count and size information
- HashMap<String, Long> objectCountMap = initializeCountMap();
- HashMap<String, Long> unReplicatedSizeMap = initializeSizeMap(false);
- HashMap<String, Long> replicatedSizeMap = initializeSizeMap(true);
- final Collection<String> taskTables = getTaskTables();
Review Comment:
Aren't the map initialisations and the `getTaskTables()` still necessary
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
