devmadhuu commented on code in PR #7723:
URL: https://github.com/apache/ozone/pull/7723#discussion_r1948050097
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTask.java:
##########
@@ -99,27 +104,28 @@ public String getTaskName() {
}
@Override
- public Pair<String, Boolean> process(OMUpdateEventBatch events) {
- long startTime = System.currentTimeMillis();
- boolean success = nsSummaryTaskWithFSO.processWithFSO(events);
- if (!success) {
+ public Pair<String, Pair<Integer, Boolean>> process(
+ OMUpdateEventBatch events, int seekPosition) {
+ Pair<Integer, Boolean> itrPosStatusPair =
+ nsSummaryTaskWithFSO.processWithFSO(events, seekPosition);
+ if (!itrPosStatusPair.getRight()) {
LOG.error("processWithFSO failed.");
}
- success = nsSummaryTaskWithLegacy.processWithLegacy(events);
- if (!success) {
+ itrPosStatusPair =
+ nsSummaryTaskWithLegacy.processWithLegacy(events, seekPosition);
+ if (!itrPosStatusPair.getRight()) {
LOG.error("processWithLegacy failed.");
}
- success = nsSummaryTaskWithOBS.processWithOBS(events);
- if (!success) {
+ itrPosStatusPair =
+ nsSummaryTaskWithOBS.processWithOBS(events, seekPosition);
+ if (!itrPosStatusPair.getRight()) {
LOG.error("processWithOBS failed.");
}
- LOG.debug("{} successfully processed in {} milliseconds",
- getTaskName(), (System.currentTimeMillis() - startTime));
- return new ImmutablePair<>(getTaskName(), success);
+ return new ImmutablePair<>(getTaskName(), itrPosStatusPair);
Review Comment:
Good catch. This has been handled now with more granular handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
