sumitagrawl commented on code in PR #7723:
URL: https://github.com/apache/ozone/pull/7723#discussion_r1951973584
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java:
##########
@@ -237,8 +246,9 @@ public synchronized void stop() {
* @param events A batch of {@link OMUpdateEventBatch} events to fetch
sequence number of last event in batch.
* @param failedTasks Reference of the list to which we want to add the
failed tasks for retry/reprocessing
*/
- private void processTasks(Collection<NamedCallableTask<Pair<String,
Boolean>>> tasks,
- OMUpdateEventBatch events, List<String>
failedTasks) {
+ private void processTasks(
+ Collection<NamedCallableTask<ReconOmTask.TaskResult>> tasks,
+ OMUpdateEventBatch events, List<Pair<String, Map<String, Integer>>>
failedTasks) {
Review Comment:
We should add index and other information to TaskResult itself, so that it
can be updated instead of creaing pair, map, ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
