peterxcli commented on code in PR #7817:
URL: https://github.com/apache/ozone/pull/7817#discussion_r1961011648
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v1/AbstractS3SDKV1Tests.java:
##########
@@ -663,33 +666,93 @@ public void testLowLevelMultipartUpload(@TempDir Path
tempDir) throws Exception
@Test
public void testListMultipartUploads() {
final String bucketName = getBucketName();
- final String multipartKey1 = getKeyName("multipart1");
- final String multipartKey2 = getKeyName("multipart2");
+ final String multipartKeyPrefix = getKeyName("multipart");
s3Client.createBucket(bucketName);
- List<String> uploadIds = new ArrayList<>();
+ // Create 25 multipart uploads to test pagination
+ List<String> allKeys = new ArrayList<>();
+ Map<String, String> keyToUploadId = new HashMap<>();
- String uploadId1 = initiateMultipartUpload(bucketName, multipartKey1,
null, null, null);
- uploadIds.add(uploadId1);
- String uploadId2 = initiateMultipartUpload(bucketName, multipartKey1,
null, null, null);
- uploadIds.add(uploadId2);
- // TODO: Currently, Ozone sorts based on uploadId instead of MPU init time
within the same key.
- // Remove this sorting step once HDDS-11532 has been implemented
Review Comment:
I reverted the changes on that test function, and put the pagination test
logic into another test func.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/s3/awssdk/v1/AbstractS3SDKV1Tests.java:
##########
@@ -663,33 +666,93 @@ public void testLowLevelMultipartUpload(@TempDir Path
tempDir) throws Exception
@Test
public void testListMultipartUploads() {
final String bucketName = getBucketName();
- final String multipartKey1 = getKeyName("multipart1");
- final String multipartKey2 = getKeyName("multipart2");
+ final String multipartKeyPrefix = getKeyName("multipart");
s3Client.createBucket(bucketName);
- List<String> uploadIds = new ArrayList<>();
+ // Create 25 multipart uploads to test pagination
+ List<String> allKeys = new ArrayList<>();
+ Map<String, String> keyToUploadId = new HashMap<>();
- String uploadId1 = initiateMultipartUpload(bucketName, multipartKey1,
null, null, null);
- uploadIds.add(uploadId1);
- String uploadId2 = initiateMultipartUpload(bucketName, multipartKey1,
null, null, null);
- uploadIds.add(uploadId2);
- // TODO: Currently, Ozone sorts based on uploadId instead of MPU init time
within the same key.
- // Remove this sorting step once HDDS-11532 has been implemented
Review Comment:
I reverted the changes on that test function, and put the pagination test
logic into new test func.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
