peterxcli commented on code in PR #7817:
URL: https://github.com/apache/ozone/pull/7817#discussion_r1957657954
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -820,19 +821,19 @@ public boolean isSstFilteringSvcEnabled() {
@Override
public OmMultipartUploadList listMultipartUploads(String volumeName,
- String bucketName, String prefix) throws OMException {
+ String bucketName, String prefix, String keyMarker, String
uploadIdMarker, int maxUploads) throws OMException {
Preconditions.checkNotNull(volumeName);
Preconditions.checkNotNull(bucketName);
metadataManager.getLock().acquireReadLock(BUCKET_LOCK, volumeName,
bucketName);
try {
- Set<String> multipartUploadKeys =
+ MultipartUploadKeys multipartUploadKeys =
Review Comment:
And I think
[L824-L857](https://github.com/apache/ozone/pull/7817/files#diff-bde0dade7dd5ddda419499f4f999d25d40fcec1412e0ce809c36ffd1be473f22R824-R857)
can be moved into OmMetadataManagerImpl, so we dont need to get info from db
again.
But maybe do in another jira issue.
@ivandika3 what do you think?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -820,19 +821,19 @@ public boolean isSstFilteringSvcEnabled() {
@Override
public OmMultipartUploadList listMultipartUploads(String volumeName,
- String bucketName, String prefix) throws OMException {
+ String bucketName, String prefix, String keyMarker, String
uploadIdMarker, int maxUploads) throws OMException {
Preconditions.checkNotNull(volumeName);
Preconditions.checkNotNull(bucketName);
metadataManager.getLock().acquireReadLock(BUCKET_LOCK, volumeName,
bucketName);
try {
- Set<String> multipartUploadKeys =
+ MultipartUploadKeys multipartUploadKeys =
Review Comment:
And I think
[L824-L857](https://github.com/apache/ozone/pull/7817/files#diff-bde0dade7dd5ddda419499f4f999d25d40fcec1412e0ce809c36ffd1be473f22R824-R857)
can be moved into `OmMetadataManagerImpl`, so we dont need to get info from db
again.
But maybe do in another jira issue.
@ivandika3 what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
