errose28 commented on a change in pull request #2056:
URL: https://github.com/apache/ozone/pull/2056#discussion_r608136411
##########
File path: hadoop-ozone/dist/src/main/compose/testlib.sh
##########
@@ -377,23 +377,14 @@ prepare_for_binary_image() {
## (no binaries included)
## @param `ozone-runner` image version (optional)
prepare_for_runner_image() {
- local default_version=${docker.ozone-runner.version} # set at build-time
from Maven property
+ local default_version=20210226-1 # set at build-time from Maven property
local runner_version=${OZONE_RUNNER_VERSION:-${default_version}} # may be
specified by user running the test
local v=${1:-${runner_version}} # prefer explicit argument
export OZONE_DIR=/opt/hadoop
export OZONE_IMAGE="apache/ozone-runner:${v}"
}
-## @description Print the logical version for a specific release
-## @param the release for which logical version should be printed
-get_logical_version() {
- local v="$1"
-
- # shellcheck source=/dev/null
- echo $(source "${_testlib_dir}/versions/${v}.sh" && ozone_logical_version)
Review comment:
Good catch, I'll take them out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
