ivanzlenko commented on code in PR #7968:
URL: https://github.com/apache/ozone/pull/7968#discussion_r1969796296
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerMetadataInspector.java:
##########
@@ -74,10 +74,13 @@
* log4j.appender.inspectorAppender.layout=org.apache.log4j.PatternLayout
*/
public class KeyValueContainerMetadataInspector implements ContainerInspector {
- public static final Logger LOG =
- LoggerFactory.getLogger(KeyValueContainerMetadataInspector.class);
- public static final Logger REPORT_LOG = LoggerFactory.getLogger(
- "ContainerMetadataInspectorReport");
+ public static final Logger LOG =
LoggerFactory.getLogger(KeyValueContainerMetadataInspector.class);
+
+ public static final Logger REPORT_LOG =
LoggerFactory.getLogger("ContainerMetadataInspectorReport");
+
+ public static final String SYSTEM_PROPERTY =
"ozone.datanode.container.metadata.inspector";
Review Comment:
I'll revert such changes and kick-off discussion on GitHub and mail list in
regards to this topic with suggestions how can we enforce one or another
approach.
P.S. I'm obviously in favor of a line separator between fields, since
typically it far more readable :) Though it varies case by case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
