adoroszlai commented on code in PR #7968:
URL: https://github.com/apache/ozone/pull/7968#discussion_r1973059903
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerMetadataInspector.java:
##########
@@ -74,10 +74,13 @@
* log4j.appender.inspectorAppender.layout=org.apache.log4j.PatternLayout
*/
public class KeyValueContainerMetadataInspector implements ContainerInspector {
- public static final Logger LOG =
- LoggerFactory.getLogger(KeyValueContainerMetadataInspector.class);
- public static final Logger REPORT_LOG = LoggerFactory.getLogger(
- "ContainerMetadataInspectorReport");
+ public static final Logger LOG =
LoggerFactory.getLogger(KeyValueContainerMetadataInspector.class);
+
+ public static final Logger REPORT_LOG =
LoggerFactory.getLogger("ContainerMetadataInspectorReport");
+
+ public static final String SYSTEM_PROPERTY =
"ozone.datanode.container.metadata.inspector";
Review Comment:
Related to empty lines: not having one between `class ...` and the first
member variable seems odd, especially when adding one between member variables.
Example:
https://github.com/apache/ozone/blob/a423b2deaed69640705e6ff006c4d9ab1066c3d4/hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/ContainerTestUtils.java#L82-L98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
