swamirishi commented on code in PR #7976:
URL: https://github.com/apache/ozone/pull/7976#discussion_r1972626219
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java:
##########
@@ -352,26 +352,22 @@ private boolean updateContainerState(final
DatanodeDetails datanode,
*/
break;
case DELETING:
+ case DELETED:
/*
- HDDS-11136: If a DELETING container has a non-empty CLOSED replica, the
container should be moved back to CLOSED
- state.
+ * HDDS-11136: If a DELETING container has a non-empty CLOSED replica,
the container should be moved back to
+ * CLOSED state.
+ *
+ * HDDS-12421: If a DELETED container has a non-empty CLOSED replica,
the container should also be moved back to
+ * CLOSED state.
*/
boolean replicaStateAllowed = replica.getState() == State.CLOSED;
boolean replicaNotEmpty = replica.hasIsEmpty() && !replica.getIsEmpty();
if (replicaStateAllowed && replicaNotEmpty) {
- logger.info("Moving DELETING container {} to CLOSED state, datanode {}
reported replica with state={}, " +
- "isEmpty={} and keyCount={}.", containerId,
datanode.getHostName(), replica.getState(), false,
- replica.getKeyCount());
- containerManager.transitionDeletingToClosedState(containerId);
+ logger.info("Moving container {} from {} to CLOSED state, datanode {}
reported replica with state={}, " +
Review Comment:
@smengcl We need not explicitly check if the container is CLOSED. we should
move the scm container state based on the state of the replica. If the
container is in OPEN/CLOSING/QUASI_CLOSED/CLOSED we should move it to the same
state or QUASI_CLOSED if the state is not in CLOSED.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
